Skip to content

🎨 Support conversation improvement (ws notification, remove unnecessary parameters) #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 22, 2025
Merged

🎨 Support conversation improvement (ws notification, remove unnecessary parameters) #8244

merged 6 commits into from
Aug 22, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Aug 21, 2025 •
edited
Loading

What do these changes do?

  • ♻️ Remove unnecessary query type parameter.
  • 🎨 In case of SUPPORT type message change notify via websocket support users + message creator

Related issue/s

How to test

Dev-ops

@matusdrobuliak66
Refactors support conversation handling and group user queries
7ff8647 
Unifies conversation query parameter handling and refines support conversation endpoints to remove unnecessary type checks from the query string.

Improves recipient notification logic for support conversations by leveraging product support groups and conversation creator identity.

Introduces a permission-free method to list all users in a group for internal use, separating caller-checked user listing from internal queries.

Simplifies frontend API calls by removing redundant type query parameters.

Supports clearer support request notifications by streamlining email templates.

Enhances maintainability and future extensibility of conversation and group logic.
@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 21, 2025
@matusdrobuliak66 matusdrobuliak66 added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:static-webserver static-webserver service labels Aug 21, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Voyager milestone Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 49.15254% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.34%. Comparing base (c94ea58) to head (318ad96).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8244      +/-   ##
==========================================
+ Coverage   83.07%   85.34%   +2.26%     
==========================================
  Files        1839      743    -1096     
  Lines       71378    34364   -37014     
  Branches     1301      175    -1126     
==========================================
- Hits        59296    29327   -29969     
+ Misses      11692     4980    -6712     
+ Partials      390       57     -333
Flag Coverage Δ
integrationtests 63.95% <23.72%> (+3.64%) ⬆️
unittests 87.25% <49.15%> (+1.78%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.84% <ø> (-0.06%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.25% <ø> (+17.39%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.13% <ø> (-2.92%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.04% <49.15%> (+4.85%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94ea58...318ad96. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 21, 2025 13:49
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 Refactors support conversation handling and group user queries 🎨 Support conversation improvement (ws notification, remove unnecessary parameters) Aug 21, 2025
odeimaiz
odeimaiz approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 318ad96.

🟢 All jobs passed!

But CI Insights is watching 👀

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) August 22, 2025 07:26
@matusdrobuliak66
Copy link
Collaborator Author

matusdrobuliak66 commented Aug 22, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 22, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit c6999c2 into ITISFoundation:master Aug 22, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 22, 2025
Merged
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:static-webserver static-webserver service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

4 participants

@matusdrobuliak66 @GitHK @odeimaiz @sanderegg